fix: improving UX for additional discount field #26495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfshanKhan
requested review from
nextchamp-saqib and
rohitwaghchaure
as code owners
AfshanKhan
force-pushed
the
fix-pos-additional-discount-displaying
branch
from
86bf137
to
5cdad07
Compare
nextchamp-saqib
approved these changes
Jul 15, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously as you can see in the gif below
Adding "Additional Discounts" changes the "Totals" but when you click on the field again the placeholder says "Enter the Discount Percentage" and the totals stays same as with the discount applied. This confuses user.
Now as you can see in the gif below
Clicking again will show the applied discount in place of "Placeholder" if any discount was applied. And user can now change the value to new discount if user wish to do so.