Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ux): set default operation time to 0 #26510

Merged
merged 1 commit into from
Jul 15, 2021
Merged

fix(ux): set default operation time to 0 #26510

merged 1 commit into from
Jul 15, 2021

Conversation

noahjacob
Copy link
Contributor

@noahjacob noahjacob commented Jul 15, 2021 •
edited

Before:

  • Threw an error if operation time was left empty.
  • No default value.
    image

Changes:

  • Default value for sub operation time is set to 0.

@noahjacob noahjacob mentioned this pull request Jul 15, 2021
Merged
@ankush ankush dismissed a stale review July 15, 2021 11:04

.

@noahjacob noahjacob changed the title fix(ux): set operation time to 0 if None fix(ux): set default operation time to 0 Jul 15, 2021
@ankush ankush merged commit 6442b5d into frappe:develop Jul 15, 2021
@coveralls
Copy link

coveralls commented Jul 15, 2021 •
edited

Coverage Status

Coverage decreased (-0.001%) to 42.914% when pulling f307b20 on noahjacob:operation-ux into eeecb25 on frappe:develop.

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@noahjacob
fix: set default operation time to 0 (frappe#26510)
d65271e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noahjacob @coveralls @ankush