ci: make semgrep check diff-aware #26516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
changed the title
ankush
force-pushed
the
diff_aware_semgrep
branch
from
3d87306
to
bd617e0
Compare
ankush
force-pushed
the
diff_aware_semgrep
branch
from
bd617e0
to
b5c5905
Compare
ankush
added a commit
to ankush/erpnext
that referenced
this pull request
Jul 15, 2021
ankush
added a commit
that referenced
this pull request
Jul 15, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change: use semgrep-action instead of CLI tool to only fail PRs which introduce a new failure.
Output:
https://github.com/returntocorp/semgrep-action/pull/292 makes semgrep-action usable with old forks that don't have config. In any case, the configs have been around for quite a long time now.