fix:Ignore mandatory fields while creating payment reconciliation Journal entry #26549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesis189
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
nemesis189
changed the title
AfshanKhan
reviewed
Jul 20, 2021
| @@ -306,5 +306,5 @@ def reconcile_dr_cr_note(dr_cr_notes, company): | |||
| } | |||
| ] | |||
| }) | |||
|
|
|||
| jv.flags.ignore_mandatory = True | |||
There was a problem hiding this comment.
@nemesis189 for which fields are we adding this? All mandatory fields are getting assigned some values right?
deepeshgarg007
approved these changes
Aug 10, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…ayment-reconcilitation fix:Ignore mandatory fields while creating payment reconciliation Journal entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore mandatory fields which prevents payment reconciliations from being created