Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ux): item description should fall back to name (#26339) #26552

Merged
merged 1 commit into from Jul 19, 2021
Merged

fix(ux): item description should fall back to name (#26339) #26552

merged 1 commit into from Jul 19, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Jul 19, 2021

Backports the following commits to version-13-hotfix:

@ankush
fix(ux): item description should fall back to name (frappe#26339)
39e1255 
Don't set item description = item code from front end. This is already
being set to item_name in before_insert and item_name is better
fallback than item code for description.

Also fixed wrong condition for erasing description while duplicating
item.
@ankush ankush added the backport This is a backported PR label Jul 19, 2021
@ankush ankush merged commit 92273ca into frappe:version-13-hotfix Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport This is a backported PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ankush