fix: SQL error on fetching RM in production plan #26592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
sql error on fetching RM from production plan
Steps to reproduce:
You'll get SQL error because the warehouse JSON is being sent to query instead of a parsed list.
Root cause:
The list is getting passed by reference and compared using
not
which would ignore the referenced list if it's empty and create new one instead.erpnext/erpnext/manufacturing/doctype/production_plan/production_plan.py
Lines 751 to 752 in 28d52c4
Solution:
check the passed reference for None, not for falseness.refactor and avoid passing by reference / mutations.