Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: employee status server-side validation #26615

Conversation

ruchamahabal
Copy link
Member

Employees with the "Inactive" status are not available for selection in transactions, not fetched in payroll or bulk attendance tool, etc. but if a record is auto-created or created from the employee link dashboard, the document can be saved. Added a server-side validation which is triggered on relevant transactions having Employee link field.

Allowing suspended employees in transactions because some organizations still process payroll, create additional salary, attendance records, etc. for a Suspended employee. So restricting creation for suspended employees can be left to their choice.

@ruchamahabal
Copy link
Member Author

PR already opened for semgrep fixes: #25901

@ruchamahabal ruchamahabal merged commit 017ed3f into frappe:version-13-hotfix Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant