Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Supplier invoice importer fix pre release #26636

Conversation

nemesis189
Copy link
Contributor

@nemesis189 nemesis189 commented Jul 26, 2021

PR: #26618

Issue:

  • This PR recently added few variables including the 'base_payment_amount' to deal with multi currency invoices.

  • The Supplier Invoice Importer tool was generating purchase invoices without adding the invoice portion in Payment Schedule due to which 'base_payment_amount' was never set (in set_payment_schedule method), causing validation error in the 'validate_payment_schedule_amount' method.
    ** validate_payment_schedule_amount, set_payment_schedule in accounts_controller.py

Fix
So in absence of invoice_portion, base_payment_amount is assigned same value as the payment_amount in the given payment schedule.

Steps:

  1. Create a company based in Italy, currency as euros. Also create a Buying Price List for this new company.
  2. Create a new entry in the Import Supplier Invoice, select the new company and buying price list, any item and tax account, supplier group as 'Services'.
  3. Select the zip file containing the invoice XMLs to be imported and import.
  4. check Error Log for any error like in the above screenshot.

@nemesis189 nemesis189 changed the title fix: Supplier invoice importer fix pre release (https://github.com/frappe/erpnext/pull/26618) fix: Supplier invoice importer fix pre release (#26618) Jul 26, 2021
@nemesis189 nemesis189 changed the title fix: Supplier invoice importer fix pre release (#26618) fix: Supplier invoice importer fix pre release [#26618](https://github.com/frappe/erpnext/pull/26618) Jul 26, 2021
@nemesis189 nemesis189 changed the title fix: Supplier invoice importer fix pre release [#26618](https://github.com/frappe/erpnext/pull/26618) fix: Supplier invoice importer fix pre release Jul 26, 2021
@deepeshgarg007 deepeshgarg007 merged commit ed68f11 into frappe:version-13-pre-release Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants