fix: Supplier invoice importer fix pre release #26636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: #26618
Issue:
This PR recently added few variables including the 'base_payment_amount' to deal with multi currency invoices.
The Supplier Invoice Importer tool was generating purchase invoices without adding the invoice portion in Payment Schedule due to which 'base_payment_amount' was never set (in set_payment_schedule method), causing validation error in the 'validate_payment_schedule_amount' method.
** validate_payment_schedule_amount, set_payment_schedule in accounts_controller.py
Fix
So in absence of invoice_portion, base_payment_amount is assigned same value as the payment_amount in the given payment schedule.
Steps: