Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e-invoicing): cannot cancel invoice if IRN cancelled on portal #26638

Merged
merged 5 commits into from
Aug 10, 2021
Merged

fix(e-invoicing): cannot cancel invoice if IRN cancelled on portal #26638

merged 5 commits into from
Aug 10, 2021

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Jul 26, 2021 •
edited

E-Invoice Cancellation Scenario

  • A user cancelled the e-invoice on the portal and didn't cancel in ERPNext
  • After 24 hours he tried cancelling the Sales Invoice which throws the error "Cancel IRN before cancelling the Sales Invoice"
  • Now, if he tries to Cancel IRN using ERPNext, the GST Portal validation doesn't allow the cancellation and throws the error
  • Ultimately, the user cannot cancel the Sales Invoice now

Fix:

  • Allow user to check IRN Cancelled checkbox manually in such cases.

@nextchamp-saqib nextchamp-saqib merged commit 84c4161 into frappe:develop Aug 10, 2021
@frappe-pr-bot
Copy link
Collaborator

The backport to version-12-hotfix failed:

The process '/usr/bin/git' failed with exit code 1

frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 10, 2021
@nextchamp-saqib @frappe-bot
fix(e-invoicing): cannot cancel invoice if IRN cancelled on portal (f…
74175e8 
…rappe#26638)

(cherry picked from commit 84c4161)
@frappe-pr-bot frappe-pr-bot mentioned this pull request Aug 10, 2021
Merged
nextchamp-saqib added a commit to nextchamp-saqib/erpnext that referenced this pull request Aug 10, 2021
@nextchamp-saqib
fix(e-invoicing): cannot cancel invoice if IRN cancelled on portal (f…
3c03599 
…rappe#26638)
@nextchamp-saqib nextchamp-saqib mentioned this pull request Aug 10, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@nextchamp-saqib
fix(e-invoicing): cannot cancel invoice if IRN cancelled on portal (f…
51beeba 
…rappe#26638)
@nextchamp-saqib nextchamp-saqib mentioned this pull request May 17, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix old-backport version-12-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nextchamp-saqib @frappe-pr-bot