Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: student category mapping from the program enrollment tool #26716

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

ruchamahabal
Copy link
Member

Before:

image

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 68, in application
    response = frappe.api.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 55, in handle
    return frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 31, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 67, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1172, in call
    return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 234, in run_doc_method
    response = doc.run_method(method)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 859, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1148, in composer
    return composed(self, method, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1131, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 853, in <lambda>
    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/education/doctype/program_enrollment_tool/program_enrollment_tool.py", line 62, in enroll_students
    prog_enrollment.student_category = stud.student_category
AttributeError: 'ProgramEnrollmentToolStudent' object has no attribute 'student_category'

After:

student-enrollment.mp4

@pateljannat pateljannat merged commit 1a2332a into frappe:develop Jul 30, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Jul 30, 2021
…e#26716)

Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com>
(cherry picked from commit 1a2332a)
pateljannat pushed a commit that referenced this pull request Jul 30, 2021
… (#26739)

Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com>
(cherry picked from commit 1a2332a)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
@HoFaks
Copy link

HoFaks commented Aug 15, 2021

we need this fix urgent .. many thanks

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…e#26716)

Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants