feat: (Stock Reco) Ignore Empty Stock while fetching items from warehouse #26726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouse - Added checkbox to `Fetch Items from Warehouse` dialog to ignore empty stock - fix: Items fetched twice due to Item Defaults - Improved code readability
marination
added
backport version-13-hotfix
needs-tests
rohitwaghchaure
approved these changes
Jul 29, 2021
|
The backport to |
| fieldtype: 'Link', | ||
| options: 'Warehouse', | ||
| reqd: 1, | ||
| "get_query": function() { |
There was a problem hiding this comment.
Can also be written as:
get_query() {
Succinct, ain't it?
| # check if item-warehouse key extracted from each entry exists in set iw_keys | ||
| # and update iw_keys | ||
| iw_keys = set() | ||
| items = [item for item in items if [(item.item_code, item.warehouse) not in iw_keys, iw_keys.add((item.item_code, item.warehouse))][0]] |
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…empty-stock feat: (Stock Reco) Ignore Empty Stock while fetching items from warehouse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch Items from WarehousepopupWorking while checked:
Working while unchecked:
Additional Fix:
no_docs