perf: Optimize get_attribute_filters #26729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested changes
Aug 11, 2021
ankush
force-pushed
the
optimize-get-attribute-filters
branch
from
91c647c
to
c52b696
Compare
nabinhait
approved these changes
Sep 14, 2021
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Sep 14, 2021
* perf: Optimize get_attribute_filters * fix: handle when filter attributes are undefined * chore: unused imports Co-authored-by: Ankush Menat <ankush@iwebnotes.com> (cherry picked from commit 1c1b476) # Conflicts: # erpnext/shopping_cart/filters.py # erpnext/www/all-products/index.html
marination
added
e-commerce-fix
marination
pushed a commit
to marination/erpnext
that referenced
this pull request
Oct 12, 2021
* perf: Optimize get_attribute_filters * fix: handle when filter attributes are undefined * chore: unused imports Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
marination
removed
backport version-13-hotfix
manual-porting-required
e-commerce-fix
1 task
marination
added a commit
that referenced
this pull request
Oct 27, 2021
…ers-hotfix perf: Optimize get_attribute_filters (#26729)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* perf: Optimize get_attribute_filters * fix: handle when filter attributes are undefined * chore: unused imports Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* perf: Optimize get_attribute_filters * fix: handle when filter attributes are undefined * chore: unused imports Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…e-filters-hotfix perf: Optimize get_attribute_filters (frappe#26729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_attribute_fitlersdid stupid computations just to fetch a list of attribute values. A simple query is faster. Tested on real site with lots of items.Before
After
Paired with @ankush and @shadrak98
@marination Please make sure to get this in E-commerce refactor.