fix: Payment Reconciliation party validation issue #26737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesis189
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
nextchamp-saqib
changed the title
|
The backport to |
|
The backport to |
|
@nemesis189 the backports have failed. You will need to create them manually. |
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…validation-fix fix: Payment Reconciliation party validation issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem :
During Payment Reconciliation, while creating new journal entries in the process the party validation caused problems for customers that were once active but now disabled.
So this means all the parties in the journal entry associated with the reconciliation needed to be active and not disabled, which is not ideal.
Solution :
Added a flag to ignore the
validate_party_frozen_disabledcheck during the validation.Steps:
create a journal entries with 2 different customers( any party)
submit the entry
disable one of the parties(in this case i disabled cust2)
Go to Payment Reconciliation, set the mandatory fields and click 'Get Unreconciled Entries', you should get the journal entry you made recently
Try and reconcile payment against that Journal entry, you should not get any errors now