feat: Ability to schedule onboarding and separation activities #26738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Developers, maybe you may consider this too please : https://discuss.erpnext.com/t/remove-auto-creation-and-auto-deletion-of-hr-doctypes-on-the-project-doctype-plus-separate-doctypes-for-creation-of-employee-contracts-on-the-contract-doctype/79072 |
ruchamahabal
requested review from
deepeshgarg007,
marination,
nextchamp-saqib,
pateljannat and
rohitwaghchaure
as code owners
ruchamahabal
removed request for
rohitwaghchaure,
nextchamp-saqib,
marination and
deepeshgarg007
|
@ruchamahabal Test case failing |
nabinhait
approved these changes
Aug 27, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…e#26738) * refactor: employee onboarding form clean-up * feat: ability to schedule onboarding / separation tasks * feat: skip holidays while setting boarding activity dates * chore: remove unused child table - Employee Onboarding Activity * fix: tests * fix: employee separation test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On submission of a new Employee Onboarding or Employee Separation, a Project is created with all the activities as Tasks. However, there is no provision to define the dates for these activities from the boarding doctype. So a user has to go to each and every task and set the start and end date.
Solution
Added 2 columns: Begin On (Days) and Duration (Days) in the Employee Boarding Activity child table (this table is used in Employee Onboarding / Separation Template as well as the original doctypes
During task creation, the start and end dates are calculated based on the specified schedule, and holidays are excluded.
employee-boarding-activities.mp4
Cleaned-up Employee Onboarding Form
Before:
After:
Removed Employee Onboarding Activity doctype (child table) as it's not being used anywhere.
no-docsDocs added in the wiki app:https://docs.erpnext.com/docs/v13/user/manual/en/human-resources/employee-separation/edit?wiki_page_patch=e97d5bdf67
https://docs.erpnext.com/docs/v13/user/manual/en/human-resources/employee-onboarding/edit?wiki_page_patch=c74c692ffc