Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use item that allows fractional UOM in test #26837

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Aug 6, 2021

The test is flaky after frappe/frappe#13880 because the UOM check uses cache and changing UOM setting right before the test might not update the cache.

Solution: use an item that already supports fractional UOM.

IRL it's not possible to change UOM and make Purchase Receipt in the same DB transaction. So this doesn't break anything.

@ankush ankush merged commit 614336f into frappe:develop Aug 6, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 6, 2021
@ankush ankush deleted the test_uom branch August 6, 2021 15:08
ankush added a commit that referenced this pull request Aug 6, 2021
(cherry picked from commit 614336f)

Co-authored-by: Ankush <ankush@iwebnotes.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant