Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: flaky tests for PR #26859

Merged
merged 1 commit into from
Aug 9, 2021
Merged

test: flaky tests for PR #26859

merged 1 commit into from
Aug 9, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Aug 9, 2021

Problem: This test is flaky and fails in weird ways due to partial commit, and its behaviour becomes difficult to understand.
Solution: Rollback after establishing that expected behaviour works.

@ankush ankush changed the title test: rollback PR changes test: rollback purchase receipt changes Aug 9, 2021
@ankush ankush changed the title test: rollback purchase receipt changes test: flaky tests for PR and LCV Aug 9, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 42.763% when pulling 2c1f37d on ankush:pr_test_rollback into b3bbebd on frappe:develop.

@ankush ankush changed the title test: flaky tests for PR and LCV test: flaky tests for PR Aug 9, 2021
@ankush ankush merged commit 7ba8c82 into frappe:develop Aug 9, 2021
@frappe-pr-bot
Copy link
Collaborator

The backport to version-13-hotfix failed:

The process '/usr/bin/git' failed with exit code 1

ankush added a commit to ankush/erpnext that referenced this pull request Aug 9, 2021
# Conflicts:
#	erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
ankush added a commit that referenced this pull request Aug 9, 2021
# Conflicts:
#	erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants