Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: from_warehouse getting set to None #26920

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

noahjacob
Copy link
Contributor

Issue

Manufacturing Settings

image

  • "Allow Multiple Material Consumption" is enabled.

Work Order Settings

image

  • "Skip Material Transfer to WIP Warehouse" is enabled while creating the work order.
  • When this setting is enabled, the WIP Warehouse field is not mandatory and can be left empty.
  • When the WIP is empty, while clicking on "Finish" to create the stock entry, the source warehouses would get set to None since it wasn't handled.

image

Fix

  • If WIP Warehouse is empty, it would set the item's set source warehouse in the stock entry detail.

image

@ankush ankush merged commit b8658d0 into frappe:develop Aug 12, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 12, 2021
ankush pushed a commit that referenced this pull request Aug 12, 2021
(cherry picked from commit b8658d0)

Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants