fix: Deferred Revenue Section should be collapsible only if its not enabled #26928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfshanKhan
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 12, 2021
…nabled (frappe#26928) (cherry picked from commit 1de4c01) # Conflicts: # erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json # erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json
AfshanKhan
added a commit
that referenced
this pull request
Aug 13, 2021
…nabled (#26930) * fix: Deferred Revenue Section should be collapsible only if its not enabled (#26928) (cherry picked from commit 1de4c01) # Conflicts: # erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json # erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json * fix: conflicts * fix: conflicts * fix: conflicts * fix: conflicts * fix: conflicts Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
sagarvora
pushed a commit
to resilient-tech/erpnext
that referenced
this pull request
Oct 2, 2021
…nabled (frappe#26930) * fix: Deferred Revenue Section should be collapsible only if its not enabled (frappe#26928) (cherry picked from commit 1de4c01) # Conflicts: # erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json # erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json * fix: conflicts * fix: conflicts * fix: conflicts * fix: conflicts * fix: conflicts Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Purchase Invoice and Sales Invoice. For the Items table, the Deferred Revenue Section should not be in collapsible state if Enable Deferred Revenue is checked.
This change aims to improved that UX.