Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replacing $.each -> forEach in SI #26995

Merged
merged 2 commits into from
Aug 24, 2021
Merged

fix: replacing $.each -> forEach in SI #26995

merged 2 commits into from
Aug 24, 2021

Conversation

anupamvs
Copy link
Contributor

No description provided.

rmehta
rmehta requested changes Aug 24, 2021
View reviewed changes
erpnext/accounts/doctype/sales_invoice/sales_invoice.js Outdated
set_timesheet_detail_rate(row.doctype, row.name, cur_frm.doc.currency, row.timesheet_detail)
});
calculate_total_billing_amount(cur_frm)
console.log(this.frm);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console?

@nabinhait nabinhait merged commit 1d6ef4b into frappe:develop Aug 24, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@anupamvs @nabinhait
fix: replacing $.each -> forEach in SI (frappe#26995)
f0f9121 
* fix: replacing $.each -> forEach in SI

* fix: removed console log

Co-authored-by: Nabin Hait <nabinhait@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmehta rmehta rmehta requested changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anupamvs @rmehta @nabinhait