fix: Return Qty in PR/DN for legacy data #27001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
approved these changes
Aug 18, 2021
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 18, 2021
(cherry picked from commit 112fc88)
ankush
pushed a commit
that referenced
this pull request
Aug 18, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
KrithiRamani
pushed a commit
to KrithiRamani/erpnext
that referenced
this pull request
Mar 14, 2022
(cherry picked from commit 112fc88) Co-authored-by: Marica <maricadsouza221197@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case:
Legacy PR with the following items:
Item: A | Qty: 100 | Row Name: abcde123
Item: A | Qty: 400 | Row Name: fghij567
Legacy PR Return with the following items:
Item: A | Qty: 300 | Against PR Item Row Name: abcde123 [Over return against first row]
In version 12, since there was no back updation from Returned PR to its original PR, and no linking between the child rows, over return against a row was not an issue
Since version 13 we check returned qty against each row. So when this patch runs to back update the returned qty, for some legacy documents, it will break throwing
OverAllowanceErrorFix:
Returned %updated that's it, since they are not compliant with the current row to row mapping.OverAllowanceError