fix: validate party and party type only if both available #27002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfshanKhan
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
deepeshgarg007
approved these changes
Aug 25, 2021
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 25, 2021
* fix: validate party and party type only if both available * fix: indentation (cherry picked from commit 8366b63)
AfshanKhan
added a commit
that referenced
this pull request
Aug 25, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* fix: validate party and party type only if both available * fix: indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
This was happening because as
Party Typeis a link field it gets validated. But till the validation happens the report gets executed withoutParty Typein the filter and whenParty Typeis validated the report again gets executed now withParty Typein filter.Now:
As
Partyfilter is aMulti-selectfield it will only show values whenParty Typeis selected. This removes the need to validate forParty Type. Hence in this PR we validatePartyonly when bothParty TypeandPartycontains value.