Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sales order qty update fails in "Update Items" button #27011

Merged
merged 1 commit into from
Aug 18, 2021
Merged

fix: Sales order qty update fails in "Update Items" button #27011

merged 1 commit into from
Aug 18, 2021

Conversation

frappe-pr-bot
Copy link
Collaborator

Backport d8a7abc from #26992

@TurkerTunali @frappe-bot
fix: date_unchanged calculation in "Update Items" (frappe#26992)
b183b94 
Branch corrected frappe#26058

  ERPNext generates "Cannot set quantity less than delivered quantity" error even the delivered qty is zero when user clicks "Update Items".
  "date_unchanged" variable gets false value because of new_date is string.

  "getdate(new_date)" corrects the date comparison.

  ![ERPNext_PR](https://user-images.githubusercontent.com/710051/121928377-c0263180-cd48-11eb-8cd9-eda7dace09d6.gif)

(cherry picked from commit d8a7abc)
@ankush ankush merged commit 44434ff into frappe:develop Aug 18, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@frappe-pr-bot @TurkerTunali
fix: date_unchanged calculation in "Update Items" (frappe#26992) (fra…
9219a13 
…ppe#27011)

Branch corrected frappe#26058

  ERPNext generates "Cannot set quantity less than delivered quantity" error even the delivered qty is zero when user clicks "Update Items".
  "date_unchanged" variable gets false value because of new_date is string.

  "getdate(new_date)" corrects the date comparison.

  ![ERPNext_PR](https://user-images.githubusercontent.com/710051/121928377-c0263180-cd48-11eb-8cd9-eda7dace09d6.gif)

(cherry picked from commit d8a7abc)

Co-authored-by: Türker Tunalı <turkert@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@marination marination Awaiting requested review from marination

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frappe-pr-bot @ankush @TurkerTunali