Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ux): removed rate from grid view #27033

Merged
merged 1 commit into from
Aug 20, 2021
Merged

fix(ux): removed rate from grid view #27033

merged 1 commit into from
Aug 20, 2021

Conversation

noahjacob
Copy link
Contributor

Before

image

Changes

  • Removed 'Rate' from the grid view.

image

  • The Rate field is only applicable if the discount type was selected as 'Rate' else would be uneditable.

rate

@nabinhait nabinhait merged commit 12d7f83 into frappe:develop Aug 20, 2021
@frappe-pr-bot
Copy link
Collaborator

The backport to version-13-hotfix failed.
Please backport the PR manually. 🤖

The process '/usr/bin/git' failed with exit code 1

@ankush ankush mentioned this pull request Aug 20, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@nabinhait
Merge pull request frappe#27033 from noahjacob/ux_promo_scheme_fix
9d35364 
fix(ux): removed rate from grid view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabinhait nabinhait nabinhait approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure

@ankush ankush Awaiting requested review from ankush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@noahjacob @frappe-pr-bot @nabinhait @ankush