Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct price list rate field value in return Sales Invoice #27097

Merged

Conversation

nemesis189
Copy link
Contributor

@nemesis189 nemesis189 commented Aug 24, 2021

Problem:
Submit a sales invoice with a different price list. Create a return credit for this submitted invoice and on expanding the item row in the items table the price list rate field will display 0 instead of the actual price list rate.

Solution:
the update_item method was setting the field to 0 in an earlier PR, removed that part.

Steps:

  1. Create a new price list rate
  2. Create an item price list rate under the new price list
  3. Create a Sales Invoice with this price list applied and submit.
  4. From the submitted invoice, create a return credit note and expand the item row and check the price list rate field.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 51.322% when pulling 76021ff on nemesis189:return-si-price-list-rate-field-fix into d4d5a42 on frappe:develop.

@nextchamp-saqib nextchamp-saqib merged commit 2e5525a into frappe:develop Aug 24, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 24, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants