refactor: payment reconciliation tool #27128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anuja-pawar
requested review from
deepeshgarg007,
marination and
rohitwaghchaure
as code owners
nextchamp-saqib
changed the title
AfshanKhan
changed the title
nextchamp-saqib
changed the title
erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js
Outdated
Show resolved
Hide resolved
nextchamp-saqib
requested changes
Aug 25, 2021
erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.json
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py
Outdated
Show resolved
Hide resolved
…a-pawar/erpnext into payment-reconciliation-tool
…a-pawar/erpnext into payment-reconciliation-tool
erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.json
Show resolved
Hide resolved
erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js
Outdated
Show resolved
Hide resolved
nextchamp-saqib
added
backport version-13-hotfix
and removed
CI-failing
…a-pawar/erpnext into payment-reconciliation-tool
…a-pawar/erpnext into payment-reconciliation-tool
…a-pawar/erpnext into payment-reconciliation-tool
This was referenced Aug 31, 2021
nextchamp-saqib
approved these changes
Aug 31, 2021
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 31, 2021
(cherry picked from commit 3e404f1) # Conflicts: # erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js # erpnext/accounts/utils.py
5 tasks
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The problem with existing tool is that a user has to manually select invoices to reconcile against payments and, only one invoice can be reconciled against particular payment at a time which makes it tedious for the cases where multiple invoices are to be reconciled against single payment or vice versa
E.g. A single payment against multiple invoices
Suppose there are 50 invoices, a user will have to select an invoice against the payment 50 times and, GL Entry of this payment also gets cancelled & submitted 50 times
Fix:
Using this refactored tool, a user will be able to select any invoice or payment to reconcile.
Once the unreconciled entries are fetched, a user can either select any particular entries or just click on Allocate button without selecting anything, Allocation table will be populated based on FIFO and/or selection, and then click on Reconcile button to reconcile all the allocated entries.