Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated and empty QUnit tests #27179

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Aug 26, 2021

Remove all empty QUnit tests. They've been deprecated for some time now.

Non-empty tests are kept for reference for migration in future.

@ankush
Copy link
Member Author

ankush commented Aug 26, 2021

Bulk deleted using:
ls **/doctype/**/test*.js | xargs wc -l | grep 23 | awk '{print $2}' | xargs rm

@ankush ankush added backport version-13-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. labels Aug 26, 2021
Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.
@ankush ankush merged commit ae55eab into frappe:develop Aug 26, 2021
@ankush ankush deleted the drop_qunit branch August 26, 2021 15:13
@ankush
Copy link
Member Author

ankush commented Aug 26, 2021

UI test failures are irrelevant... will get it fixed separately.

frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 26, 2021
* chore: remove deprecated and empty QUnit tests

* ci: fix UI test config

Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.

(cherry picked from commit ae55eab)
ankush added a commit that referenced this pull request Aug 26, 2021
* chore: remove deprecated and empty QUnit tests

* ci: fix UI test config

Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.

(cherry picked from commit ae55eab)

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
* chore: remove deprecated and empty QUnit tests

* ci: fix UI test config

Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-13-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants