Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "refactor: simplify initialize_previous_data" #27270

Merged
merged 1 commit into from
Aug 31, 2021
Merged

revert: "refactor: simplify initialize_previous_data" #27270

merged 1 commit into from
Aug 31, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Aug 31, 2021 •
edited

reverts one of the commits in #26775 as this is flawed.

@ankush ankush changed the title revert "refactor: simplify initialize_previous_data" revert: "refactor: simplify initialize_previous_data" Aug 31, 2021
@ankush ankush merged commit c1d986a into frappe:develop Aug 31, 2021
@ankush ankush deleted the revert_init_prev_data branch August 31, 2021 14:13
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 31, 2021
@ankush @frappe-bot
fix: revert "refactor: simplify initialize_previous_data" (frappe#27270)
512417a 
This reverts commit 2f5624e.

(cherry picked from commit c1d986a)
@frappe-pr-bot frappe-pr-bot mentioned this pull request Aug 31, 2021
Merged
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 31, 2021
@ankush @frappe-bot
fix: revert "refactor: simplify initialize_previous_data" (frappe#27270)
8d381d8 
This reverts commit 2f5624e.

(cherry picked from commit c1d986a)
@frappe-pr-bot frappe-pr-bot mentioned this pull request Aug 31, 2021
Merged
ankush added a commit that referenced this pull request Aug 31, 2021
@frappe-pr-bot @ankush
fix: revert "refactor: simplify initialize_previous_data" (#27270) (#…
d641dd6 
…27271)

This reverts commit 2f5624e.

(cherry picked from commit c1d986a)

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
ankush added a commit that referenced this pull request Aug 31, 2021
@frappe-pr-bot @ankush
fix: revert "refactor: simplify initialize_previous_data" (#27270) (#…
1b338d6 
…27272)

This reverts commit 2f5624e.

(cherry picked from commit c1d986a)

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 51.531% when pulling 18f91ed on ankush:revert_init_prev_data into 763450d on frappe:develop.

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ankush
fix: revert "refactor: simplify initialize_previous_data" (frappe#27270)
0fa3b1d 
This reverts commit 2f5624e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ankush @coveralls