ci(semgrep): add translation checks for report labels #27280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
reviewed
Sep 1, 2021
path can't be applied on a test id basis
|
@ankush 2 FNs in the tests, this doesn't seem to be happening in |
|
@18alantom that's probably because test runner is respecting the glob pattern. It's a bug IMO. Ignore it for now. |
ankush
reviewed
Sep 1, 2021
ankush
approved these changes
Sep 1, 2021
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Sep 1, 2021
* ci(semgrep): add translation checks for report labels * refactor: shift report tests to it's own yml path can't be applied on a test id basis * ci: ignore regional report in translation checks [skip ci] (cherry picked from commit 72ece75)
ankush
pushed a commit
that referenced
this pull request
Sep 1, 2021
* ci(semgrep): add translation checks for report labels * refactor: shift report tests to it's own yml path can't be applied on a test id basis * ci: ignore regional report in translation checks [skip ci] (cherry picked from commit 72ece75) Co-authored-by: Alan <2.alan.tom@gmail.com>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* ci(semgrep): add translation checks for report labels * refactor: shift report tests to it's own yml path can't be applied on a test id basis * ci: ignore regional report in translation checks [skip ci]
KrithiRamani
pushed a commit
to KrithiRamani/erpnext
that referenced
this pull request
Mar 14, 2022
…rappe#27286) * ci(semgrep): add translation checks for report labels * refactor: shift report tests to it's own yml path can't be applied on a test id basis * ci: ignore regional report in translation checks [skip ci] (cherry picked from commit 72ece75) Co-authored-by: Alan <2.alan.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add translation checks for report labels
I know this 👇 looks ugly
but
yamlasks me to wrap the pattern in quotes when writing it this way: