Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make datetime objects readable #27301

Merged
merged 4 commits into from
Sep 3, 2021

Conversation

GangaManoj
Copy link
Contributor

@GangaManoj GangaManoj commented Sep 1, 2021

Problem:

Datetime objects in all the old tests in test_issue.py have all been written like datetime.datetime(2019, 3, 4, 12, 0), which isn't very readable.

Fix:

Use get_datetime to write them instead.
eg: Replace datetime.datetime(2019, 3, 4, 12, 0) with get_datetime("2019-03-04 12:00").

@coveralls
Copy link

coveralls commented Sep 1, 2021

Coverage Status

Coverage remained the same at 51.551% when pulling c4defc6 on GangaManoj:make-datetime-objects-readable into d1fe060 on frappe:develop.

@ankush ankush merged commit 64fcd1a into frappe:develop Sep 3, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
* fix: Make datetime objects readable

* fix: Remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants