Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor linting issues #27314

Merged
merged 3 commits into from
Sep 2, 2021
Merged

fix: minor linting issues #27314

merged 3 commits into from
Sep 2, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Sep 2, 2021

  • wrong arguments for delete_accounting_dimension
  • incorrect frappe.throw statement
  • unpacking None

@ankush ankush added backport version-13-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. labels Sep 2, 2021
@ankush ankush merged commit eec4051 into frappe:develop Sep 2, 2021
@ankush ankush deleted the linting_issuess branch September 2, 2021 12:12
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Sep 2, 2021
@ankush @frappe-bot
fix: minor linting issues (frappe#27314)
c4fe062 
* fix: syntax error in gratuity

* fix: unpacking None into three variables

* fix: unexpected kwarg for delete_accounting_dimensions

(cherry picked from commit eec4051)
@frappe-pr-bot frappe-pr-bot mentioned this pull request Sep 2, 2021
Merged
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 51.538% when pulling b596e69 on ankush:linting_issuess into 8b1a61b on frappe:develop.

ankush added a commit that referenced this pull request Sep 2, 2021
@frappe-pr-bot @ankush
fix: minor linting issues (#27314) (#27315)
0fd037e 
* fix: syntax error in gratuity

* fix: unpacking None into three variables

* fix: unexpected kwarg for delete_accounting_dimensions

(cherry picked from commit eec4051)

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ankush
fix: minor linting issues (frappe#27314)
98e20b6 
* fix: syntax error in gratuity

* fix: unpacking None into three variables

* fix: unexpected kwarg for delete_accounting_dimensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@pateljannat pateljannat Awaiting requested review from pateljannat

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal

Assignees
No one assigned
Labels
backport version-13-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ankush @coveralls