Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Paging and Discount filter #27332

Merged
merged 3 commits into from Sep 3, 2021
Merged

fix: Paging and Discount filter #27332

merged 3 commits into from Sep 3, 2021

Conversation

marination
Copy link
Collaborator

Issue:

  • Paging button breaks
  • Due to change from 10% and above to 10% and below, filtering broke due to not changing filter behaviour in api.py

Fix:

  • Convert incoming api args to frappe dict
  • Change discount filter condition due to reversal of behaviour

@marination
fix: Paging and Discount filter
99ec4cc 
- Convert incoming api args to frappe dict
- Change discount filter condition due to reversal of behaviour
@marination
fix: Linter (whitespace)
a32bb25
@marination marination merged commit aee2e04 into frappe:version-13-hotfix Sep 3, 2021
@marination marination added the e-commerce-fix E-commerce PRs that need to be front ported to develop label Sep 9, 2021
@rohitwaghchaure rohitwaghchaure mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
e-commerce-fix E-commerce PRs that need to be front ported to develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marination