Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix to fetch customers and billing email in PSOA #27363

Merged
merged 7 commits into from
Sep 9, 2021
Merged

fix: fix to fetch customers and billing email in PSOA #27363

merged 7 commits into from
Sep 9, 2021

Conversation

Anuja-pawar
Copy link
Contributor

@Anuja-pawar Anuja-pawar commented Sep 6, 2021 •
edited

Issue:
Process Statement of Accounts -

  • System throws the following error even when one has a customer with primary contact email because billing email is missing.
    Screenshot 2021-09-06 at 8 49 10 PM
  • Query to fetch billing email failed to do so

Fix:

  • Fixed the condition to fetch customers
  • Fixed a query to fetch billing email
  • Added a description to the checkbox which goes otherwise unnoticed
    psoa

@coveralls
Copy link

coveralls commented Sep 6, 2021 •
edited

Coverage Status

Coverage decreased (-0.03%) to 51.614% when pulling 55a75cb on Anuja-pawar:process-statement-of-accounts into 2950204 on frappe:develop.

@nextchamp-saqib nextchamp-saqib merged commit a58e309 into frappe:develop Sep 9, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Sep 9, 2021
@Anuja-pawar @frappe-bot
fix: fix to fetch customers and billing email in PSOA (frappe#27363)
07a690c 
(cherry picked from commit a58e309)

# Conflicts:
#	erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json
@frappe-pr-bot frappe-pr-bot mentioned this pull request Sep 9, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@Anuja-pawar
fix: fix to fetch customers and billing email in PSOA (frappe#27363)
5415edf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextchamp-saqib nextchamp-saqib nextchamp-saqib approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Anuja-pawar @coveralls @nextchamp-saqib