Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: document naming rule not working for subscription invoices #27386

Merged
merged 1 commit into from
Sep 8, 2021
Merged

fix: document naming rule not working for subscription invoices #27386

merged 1 commit into from
Sep 8, 2021

Conversation

nextchamp-saqib
Copy link
Member

Document Naming Rule on Sales Invoice

CleanShot 2021-09-08 at 13 46 37@2x

Created a Subscription for the Company associated with that Company GSTIN

Now clicking on Fetch Subscription Updates on the Subscription document creates a Sales Invoice with default naming instead of following the Document Naming Rule.

This is because the Company GSTIN is set in the validate method of Sales Invoice while the naming is set before validate, hence while setting the name, the Company GSTIN condition is false

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 51.657% when pulling e363dd3 on nextchamp-saqib:sub-set-missing-values into 5596988 on frappe:develop.

@nextchamp-saqib nextchamp-saqib merged commit 9c27f9b into frappe:develop Sep 8, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Sep 8, 2021
@nextchamp-saqib @frappe-bot
fix: document naming rule not working for subscription invoices (frap…
6030a06 
…pe#27386)

(cherry picked from commit 9c27f9b)

# Conflicts:
#	erpnext/accounts/doctype/subscription/subscription.py
@frappe-pr-bot frappe-pr-bot mentioned this pull request Sep 8, 2021
Merged
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Sep 8, 2021
@nextchamp-saqib @frappe-bot
fix: document naming rule not working for subscription invoices (frap…
178a6e0 
…pe#27386)

(cherry picked from commit 9c27f9b)

# Conflicts:
#	erpnext/accounts/doctype/subscription/subscription.py
@frappe-pr-bot frappe-pr-bot mentioned this pull request Sep 8, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@nextchamp-saqib
fix: document naming rule not working for subscription invoices (frap…
3c1a5ee 
…pe#27386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix old-backport version-12-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nextchamp-saqib @coveralls