Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove snyk from devdependencies #27406

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Sep 9, 2021

  • Use dependabot only for ERPNext's dependencies.
  • ERPNext only has 2 real dependencies. However, by adding snyk total package count goes to 567!

@rmehta rmehta marked this pull request as ready for review September 9, 2021 07:37
@rmehta rmehta merged commit 95e440b into frappe:develop Sep 9, 2021
@ankush ankush added manual-porting-required Skip Manual Testing The changes in this PR does not require manual testing and removed discussion labels Sep 9, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.636% when pulling 518f827 on ankush:remove_snyk into 678335f on frappe:develop.

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
chore: remove snyk from devdependencies
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants