Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: .doc missing and empty row on new doc #27408

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

noahjacob
Copy link
Contributor

@noahjacob noahjacob commented Sep 9, 2021

Changes

  • Added missing .doc in frm.maintenance_type.
  • Clearing empty table row on creating a new visit.

table

After Changes

table_fix

@ankush ankush merged commit acdb103 into frappe:develop Sep 9, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Sep 9, 2021
* refactor: .doc missing and empty row on new doc

* fix: let -> const

(cherry picked from commit acdb103)

# Conflicts:
#	erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Sep 9, 2021
* refactor: .doc missing and empty row on new doc

* fix: let -> const

(cherry picked from commit acdb103)
ankush pushed a commit that referenced this pull request Sep 9, 2021
* refactor: .doc missing and empty row on new doc

* fix: let -> const

(cherry picked from commit acdb103)

Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
* refactor: .doc missing and empty row on new doc

* fix: let -> const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants