Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cancelled sales invoices are considered in billed qty calculation #27465

Merged

Conversation

nextchamp-saqib
Copy link
Member

In the Sales Order Analytics report, the billed quantity was calculated considering cancelled Sales Invoices.

So, if there were 2 sales invoices created against a sales order and one of them was cancelled then the billed quantity showed invalid value.

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #27465 (44139fb) into develop (7292f54) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #27465   +/-   ##
========================================
  Coverage    52.80%   52.81%           
========================================
  Files         1332     1332           
  Lines        70576    70580    +4     
========================================
+ Hits         37266    37275    +9     
+ Misses       33310    33305    -5     
Impacted Files Coverage Δ
...eport/sales_order_analysis/sales_order_analysis.py 0.00% <ø> (ø)
erpnext/accounts/deferred_revenue.py 74.55% <0.00%> (-0.90%) ⬇️
erpnext/stock/reorder_item.py 75.22% <0.00%> (-0.89%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 67.90% <0.00%> (-0.44%) ⬇️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.34% <0.00%> (-0.27%) ⬇️
erpnext/accounts/utils.py 59.51% <0.00%> (-0.19%) ⬇️
erpnext/payroll/doctype/salary_slip/salary_slip.py 83.42% <0.00%> (+0.22%) ⬆️
...ype/account/chart_of_accounts/chart_of_accounts.py 79.31% <0.00%> (+0.68%) ⬆️
erpnext/support/doctype/issue/issue.py 64.56% <0.00%> (+0.97%) ⬆️
erpnext/portal/utils.py 31.42% <0.00%> (+1.42%) ⬆️
... and 4 more

@deepeshgarg007 deepeshgarg007 merged commit c7ceb37 into frappe:develop Sep 14, 2021
@frappe-pr-bot
Copy link
Collaborator

The backport to version-13-hotfix failed.
Please backport the PR manually. 🤖

The process '/usr/bin/git' failed with exit code 1

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…ort-fix

fix: cancelled sales invoices are considered in billed qty calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants