-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Asset capitalization #27466
feat: Asset capitalization #27466
Conversation
(hotfix label is to avoid auto-closure of PRs by stale bot, looks weird but eh...) |
…t-capitalization # Conflicts: # erpnext/accounts/doctype/sales_invoice/sales_invoice.py # erpnext/assets/doctype/asset/test_asset.py # erpnext/assets/workspace/assets/assets.json
Codecov Report
@@ Coverage Diff @@
## develop #27466 +/- ##
===========================================
+ Coverage 55.20% 55.46% +0.25%
===========================================
Files 1121 1125 +4
Lines 66751 67190 +439
===========================================
+ Hits 36853 37264 +411
- Misses 29898 29926 +28
|
…tion # Conflicts: # erpnext/accounts/doctype/sales_invoice/sales_invoice.py
isort error is due to merging develop branch in this PR |
It's not from the merge. You removed an unused import, so it now fits on a single line. Just add pre-commit hook to avoid this manual work 😄 |
We are planning to separate the Asset module into an App. So, this will be moved to the App once we have moved all the existing features. Hence closing this for now. |
As we have changed our plan for a separate Asset app, reopening the PR. |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
🎉 This PR is included in version 14.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Documentation (Under Review):
https://docs.erpnext.com/docs/v13/user/manual/en/asset/new?wiki_page_patch=ee64cad18b
Dependent On:
#27585
Example Capitalization Entry
Example Decapitalization Entry