Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plaid): query to check if bank account exists #27534

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

nextchamp-saqib
Copy link
Member

Problem:

Plaid Integration auto-creates Bank Accounts. These bank accounts have names based on Account Name & Bank field.

In case the bank field in the Bank Account is changed or renamed, then while refreshing the Plaid Link, the existing/already created Bank Account is not found based on Account Name & Bank filters.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #27534 (60d4d99) into develop (f07ff92) will increase coverage by 0.13%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop   #27534      +/-   ##
===========================================
+ Coverage    54.42%   54.55%   +0.13%     
===========================================
  Files         1333     1333              
  Lines        70723    70725       +2     
===========================================
+ Hits         38491    38586      +95     
+ Misses       32232    32139      -93     
Impacted Files Coverage Δ
...egrations/doctype/plaid_settings/plaid_settings.py 46.75% <50.00%> (+0.04%) ⬆️
erpnext/education/doctype/student/student.py 74.46% <0.00%> (-3.20%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
erpnext/support/doctype/issue/issue.py 63.59% <0.00%> (-0.98%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.41% <0.00%> (-0.70%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.55% <0.00%> (-0.58%) ⬇️
erpnext/stock/stock_ledger.py 85.76% <0.00%> (-0.55%) ⬇️
erpnext/hr/utils.py 72.80% <0.00%> (-0.44%) ⬇️
... and 21 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant