Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing unused fields from workspace JSON files #27612

Merged
merged 5 commits into from
Oct 13, 2021

Conversation

shariquerik
Copy link
Member

Removing unused fields from workspace JSON files

@shariquerik shariquerik marked this pull request as draft September 20, 2021 16:25
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #27612 (7bef8b0) into develop (8d69ec7) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #27612      +/-   ##
===========================================
- Coverage    54.41%   54.32%   -0.10%     
===========================================
  Files         1254     1254              
  Lines        67735    67735              
===========================================
- Hits         36856    36795      -61     
- Misses       30879    30940      +61     
Impacted Files Coverage Δ
...eport/item_variant_details/item_variant_details.py 32.14% <0.00%> (-52.39%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.81% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 69.49% <0.00%> (-22.04%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 68.33% <0.00%> (-10.00%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 84.17% <0.00%> (-5.76%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 90.09% <0.00%> (-2.98%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 87.01% <0.00%> (-1.30%) ⬇️
erpnext/stock/stock_ledger.py 85.94% <0.00%> (-1.09%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 78.82% <0.00%> (-0.59%) ⬇️
... and 16 more

@shariquerik shariquerik marked this pull request as ready for review September 27, 2021 06:04
@stale stale bot added the inactive label Oct 12, 2021
@frappe frappe deleted a comment from stale bot Oct 12, 2021
@ankush ankush merged commit 790c1cd into frappe:develop Oct 13, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
fix: Removing unused fields from workspace JSON files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants