fix: tax rate being overridden in case of 0.00 #27660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tax rate could be different for different expenses. Therefore, rate is kept as 0.00 and tax amount entered manually. But fetching used to override the rate(upon saving) and mess up the amount.
|
Introducing an expense tax template (like in case of items in invoices) would be a better way to handle taxes. |
erpnext/hr/doctype/expense_taxes_and_charges/expense_taxes_and_charges.json
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #27660 +/- ##
===========================================
+ Coverage 54.49% 54.56% +0.07%
===========================================
Files 1333 1333
Lines 70736 70737 +1
===========================================
+ Hits 38545 38596 +51
+ Misses 32191 32141 -50
|
|
@Mergifyio backport version-12-hotfix version-13-hotfix |
This was referenced Oct 5, 2021
|
Command
|
marination
added a commit
that referenced
this pull request
Oct 5, 2021
…-27660 fix: tax rate being overridden in case of 0.00 (backport #27660)
|
@rtdany10 In this the modified timestamp wasn't changed so the changes didn't apply on migrate, can raise a PR to fix this |
My bad, will raise a PR. Thanks! |
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
fix: tax rate being overridden in case of 0.00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In expense claim, tax rate could be different for different expenses.
Therefore, rate is kept as 0.00 and tax amount entered manually in the tax table.
But fetch functionality overrides the tax rate (upon saving) and mess up the amount.
This PR removes the fetch functionality of the rate column.
#no-docs Please backport to v13 and v12 as well.