refactor: fetching of account balance in chart of accounts #27661

nextchamp-saqib · 2021-09-27T05:47:06Z

Before:

Took ~40 secs

After:

Took 18 secs

Changes:

Display Nodes and then Asynchronously fetch balance
Only fetch balance if the user has permissions for GL Entry

Depends On: frappe/frappe#14310

codecov · 2021-09-27T06:05:47Z

Codecov Report

Merging #27661 (68668e9) into develop (5e0b215) will increase coverage by 8.08%.
The diff coverage is 78.57%.

@@             Coverage Diff             @@
##           develop   #27661      +/-   ##
===========================================
+ Coverage    46.53%   54.61%   +8.08%     
===========================================
  Files         1333     1333              
  Lines        70679    70745      +66     
===========================================
+ Hits         32888    38640    +5752     
+ Misses       37791    32105    -5686

Impacted Files	Coverage Δ
erpnext/hooks.py	`0.00% <ø> (ø)`
...cturing/doctype/production_plan/production_plan.py	`69.78% <ø> (+57.28%)`	⬆️
erpnext/regional/india/setup.py	`95.23% <ø> (ø)`
erpnext/regional/report/gstr_1/gstr_1.py	`0.00% <0.00%> (ø)`
erpnext/accounts/utils.py	`59.19% <21.42%> (+0.04%)`	⬆️
...ctype/stock_reconciliation/stock_reconciliation.py	`82.85% <33.33%> (+0.14%)`	⬆️
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py	`74.70% <50.00%> (+0.20%)`	⬆️
erpnext/tests/utils.py	`97.67% <93.33%> (-2.33%)`	⬇️
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py	`70.44% <100.00%> (+9.77%)`	⬆️
...xt/accounts/doctype/sales_invoice/sales_invoice.py	`75.42% <100.00%> (+1.24%)`	⬆️
... and 209 more

nextchamp-saqib · 2021-10-04T06:14:21Z

@Mergifyio backport version-13-hotfix

mergify · 2021-10-04T06:14:37Z

Command backport version-13-hotfix: pending

backport version-13-hotfix is pending

(cherry picked from commit 9051735)

mergify · 2021-10-04T06:15:36Z

Command backport version-13-hotfix: success

Backports have been created

#27764 refactor: fetching of account balance in chart of accounts (backport #27661) has been created for branch version-13-hotfix

(cherry picked from commit 9051735)

…-27661 refactor: fetching of account balance in chart of accounts (backport #27661)

(cherry picked from commit 9051735)

* fix: Account number and name incorrectly import using COA importer (cherry picked from commit 17a8649) * frappe#27775 * fix: Totals row incorrect value in GL Entry (frappe#27867) (cherry picked from commit ebe68c1) * frappe#27862 * frappe#27915 * fix: Item Variant selection empty popup on website - pass item_code instead of website item name to fetch attributes * perf: fetching of account balance in chart of accounts (frappe#27661) (cherry picked from commit 9051735) * frappe#27748 * fix: Website Items with same Item name unhandled, thumbnails missing - Use naming series for Website Item. There could be two items with same name and different item code - Fix: Website Item Page view breaks if cart is disabled - Fix: thumbnails not created for Website Items after patch - Fix: ‘Request for Quote’ button & cart summary not visible if checkout is disabled (cherry picked from commit 36b519c) * fix: Pre-commit formatting (cherry picked from commit 77d4849) * fix: Delete linked Transaction Deletion Record docs on deleting company (cherry picked from commit 38c7e42) * frappe#27763 * frappe#27732 * fix: consolidated report not consider company currency (cherry picked from commit dc42064) * fix: opening balance to calculate 'Unclosed Fiscal Years Profit / Loss (Credit)' (cherry picked from commit 19d14da) * frappe#27804 * fix: consolitated financial statement * fix: chart of account Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Saqib <nextchamp.saqib@gmail.com> Co-authored-by: GangaManoj <ganga.manoj98@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>

(cherry picked from commit 9051735)

* fix: Account number and name incorrectly import using COA importer (cherry picked from commit 17a8649) * frappe#27775 * fix: Totals row incorrect value in GL Entry (frappe#27867) (cherry picked from commit ebe68c1) * frappe#27862 * frappe#27915 * fix: Item Variant selection empty popup on website - pass item_code instead of website item name to fetch attributes * perf: fetching of account balance in chart of accounts (frappe#27661) (cherry picked from commit 9051735) * frappe#27748 * fix: Website Items with same Item name unhandled, thumbnails missing - Use naming series for Website Item. There could be two items with same name and different item code - Fix: Website Item Page view breaks if cart is disabled - Fix: thumbnails not created for Website Items after patch - Fix: ‘Request for Quote’ button & cart summary not visible if checkout is disabled (cherry picked from commit 36b519c) * fix: Pre-commit formatting (cherry picked from commit 77d4849) * fix: Delete linked Transaction Deletion Record docs on deleting company (cherry picked from commit 38c7e42) * frappe#27763 * frappe#27732 * fix: consolidated report not consider company currency (cherry picked from commit dc42064) * fix: opening balance to calculate 'Unclosed Fiscal Years Profit / Loss (Credit)' (cherry picked from commit 19d14da) * frappe#27804 * fix: consolitated financial statement * fix: chart of account Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Saqib <nextchamp.saqib@gmail.com> Co-authored-by: GangaManoj <ganga.manoj98@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>

(cherry picked from commit 9051735)

* fix: Account number and name incorrectly import using COA importer (cherry picked from commit 17a8649) * fix * fix: Totals row incorrect value in GL Entry (frappe#27867) (cherry picked from commit ebe68c1) * frappe#27862 * frappe#27915 * fix: Item Variant selection empty popup on website - pass item_code instead of website item name to fetch attributes * perf: fetching of account balance in chart of accounts (frappe#27661) (cherry picked from commit 9051735) * frappe#27748 * fix: Website Items with same Item name unhandled, thumbnails missing - Use naming series for Website Item. There could be two items with same name and different item code - Fix: Website Item Page view breaks if cart is disabled - Fix: thumbnails not created for Website Items after patch - Fix: ‘Request for Quote’ button & cart summary not visible if checkout is disabled (cherry picked from commit 36b519c) * fix: Pre-commit formatting (cherry picked from commit 77d4849) * fix: Delete linked Transaction Deletion Record docs on deleting company (cherry picked from commit 38c7e42) * fix * frappe#27732 * fix: consolidated report not consider company currency (cherry picked from commit dc42064) * fix: opening balance to calculate 'Unclosed Fiscal Years Profit / Loss (Credit)' (cherry picked from commit 19d14da) * frappe#27804 Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Saqib <nextchamp.saqib@gmail.com> Co-authored-by: GangaManoj <ganga.manoj98@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>

refactor: fetching of account balance in chart of accounts

3111a66

nextchamp-saqib requested a review from deepeshgarg007 as a code owner September 27, 2021 05:47

deepeshgarg007 added the backport version-13-hotfix label Sep 27, 2021

nextchamp-saqib added 2 commits September 28, 2021 18:01

refactor: fetching of account balances when node is expanded

4519a85

fix: sider

68668e9

nextchamp-saqib enabled auto-merge (squash) September 28, 2021 14:50

nextchamp-saqib disabled auto-merge September 29, 2021 06:02

nextchamp-saqib merged commit 9051735 into frappe:develop Oct 4, 2021

mergify bot pushed a commit that referenced this pull request Oct 4, 2021

perf: fetching of account balance in chart of accounts (#27661)

c0b17ed

(cherry picked from commit 9051735)

mergify bot mentioned this pull request Oct 4, 2021

refactor: fetching of account balance in chart of accounts (backport #27661) #27764

Merged

frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Oct 4, 2021

perf: fetching of account balance in chart of accounts (frappe#27661)

43235fc

(cherry picked from commit 9051735)

frappe-pr-bot mentioned this pull request Oct 4, 2021

refactor: fetching of account balance in chart of accounts #27765

Closed

marination added a commit that referenced this pull request Oct 6, 2021

Merge pull request #27764 from frappe/mergify/bp/version-13-hotfix/pr…

71f676e

…-27661 refactor: fetching of account balance in chart of accounts (backport #27661)

rohitwaghchaure mentioned this pull request Oct 20, 2021

chore: change log for v13.13.0 #28040

Merged

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021

perf: fetching of account balance in chart of accounts (frappe#27661)

5c6cc13

fproldan pushed a commit to fproldan/erpnext that referenced this pull request May 19, 2022

perf: fetching of account balance in chart of accounts (frappe#27661)

037b560

(cherry picked from commit 9051735)

fproldan pushed a commit to fproldan/erpnext that referenced this pull request May 20, 2022

perf: fetching of account balance in chart of accounts (frappe#27661)

b750677

(cherry picked from commit 9051735)

fproldan pushed a commit to fproldan/erpnext that referenced this pull request Jun 24, 2022

perf: fetching of account balance in chart of accounts (frappe#27661)

96c1bd2

(cherry picked from commit 9051735)

fproldan pushed a commit to fproldan/erpnext that referenced this pull request Jun 24, 2022

perf: fetching of account balance in chart of accounts (frappe#27661)

e60089d

(cherry picked from commit 9051735)

fproldan pushed a commit to fproldan/erpnext that referenced this pull request Jun 24, 2022

perf: fetching of account balance in chart of accounts (frappe#27661)

3ed4e96

(cherry picked from commit 9051735)

deepeshgarg007 mentioned this pull request Jul 18, 2022

List of V14 features & enhancements #31620

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: fetching of account balance in chart of accounts #27661

refactor: fetching of account balance in chart of accounts #27661

nextchamp-saqib commented Sep 27, 2021 •

edited

codecov bot commented Sep 27, 2021 •

edited

nextchamp-saqib commented Oct 4, 2021

mergify bot commented Oct 4, 2021

mergify bot commented Oct 4, 2021

refactor: fetching of account balance in chart of accounts #27661

refactor: fetching of account balance in chart of accounts #27661

Conversation

nextchamp-saqib commented Sep 27, 2021 • edited

Before:

After:

codecov bot commented Sep 27, 2021 • edited

Codecov Report

nextchamp-saqib commented Oct 4, 2021

mergify bot commented Oct 4, 2021

mergify bot commented Oct 4, 2021

nextchamp-saqib commented Sep 27, 2021 •

edited

codecov bot commented Sep 27, 2021 •

edited