Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot set custom label for 'total' field in print format #27664

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

nextchamp-saqib
Copy link
Member

The 'Total' field is rendered with a custom template in Sales Invoice print formats.

The template fetches the label from meta, which required users to change the label from the Customize Form to change the label in print format

To test the fix:

  • Open any custom print format of Sales Invoice
  • Using Print Format Builder, change the label of Total field
  • Check if the label is changed in any document's print preview.

@nextchamp-saqib
Copy link
Member Author

@Mergifyio backport enterprise-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2021

Command backport enterprise-hotfix: pending

backport enterprise-hotfix is pending

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #27664 (cd32de7) into develop (f8c1c73) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #27664      +/-   ##
===========================================
+ Coverage    54.49%   54.52%   +0.03%     
===========================================
  Files         1333     1333              
  Lines        70736    70740       +4     
===========================================
+ Hits         38545    38574      +29     
+ Misses       32191    32166      -25     
Impacted Files Coverage Δ
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
erpnext/stock/reorder_item.py 75.22% <0.00%> (-0.89%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 75.55% <0.00%> (-0.75%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.41% <0.00%> (-0.70%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.55% <0.00%> (-0.58%) ⬇️
... and 20 more

@nextchamp-saqib nextchamp-saqib merged commit f2fca59 into frappe:develop Sep 27, 2021
@nextchamp-saqib
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2021

Command backport enterprise-hotfix: success

Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2021

Command backport version-13-hotfix: success

Backports have been created

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant