Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display appropriate message for Payment Term discrepancies in Payment Entry #27749

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

GangaManoj
Copy link
Contributor

Problem:

When a Payment Entry is created for an Invoice, but the Payment Term in the Payment Entry does not correspond with the ones used in the Invoice, the following message is displayed:

Screenshot 2021-10-02 at 8 50 37 PM

This doesn't give a clear indication of the problem, i.e. the mismatch in Payment Terms.

Fix:

Display the following message instead.

Screenshot 2021-10-02 at 9 07 46 PM

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #27749 (9f14695) into develop (4e7ec8a) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop   #27749      +/-   ##
===========================================
- Coverage    54.59%   54.56%   -0.04%     
===========================================
  Files         1343     1343              
  Lines        71044    71046       +2     
===========================================
- Hits         38786    38765      -21     
- Misses       32258    32281      +23     
Impacted Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 69.59% <50.00%> (-0.04%) ⬇️
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.81% <0.00%> (-24.53%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...t/payroll/doctype/payroll_period/payroll_period.py 65.45% <0.00%> (-5.46%) ⬇️
erpnext/education/doctype/student/student.py 74.46% <0.00%> (-3.20%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 77.50% <0.00%> (-2.50%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
... and 21 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2021

Command backport version-13-hotfix: success

Backports have been created

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
fix: Display appropriate message for Payment Term discrepancies in Payment Entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants