-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Subscription): reorder updation of end date #27783
fix(Subscription): reorder updation of end date #27783
Conversation
hrwX
commented
Oct 4, 2021
- closes issue/#27521
- frontport of #27782
fb01faa
to
3a89685
Compare
Codecov Report
@@ Coverage Diff @@
## develop #27783 +/- ##
========================================
Coverage 54.55% 54.56%
========================================
Files 1248 1248
Lines 67518 67527 +9
========================================
+ Hits 36836 36846 +10
+ Misses 30682 30681 -1
|
7c027bf
to
656015d
Compare
2be35f5
to
ae657c7
Compare
@deepeshgarg007 why did you remove the backport-version-12-hotfix label? We found this issue in v12 and our main intention is fixing it there. |
The subscription doctype in v13 and v12 are quite different so I don't think an automated backport to v12 might have worked hence I removed the label. Also, we have stopped backporting using labels and using mergify for backporting now. |
@deepeshgarg007 thanks for the clarification. Lets get this merged and we'll see about the backport later. |
@Mergifyio backport version-13-hotfix |
Command
|
…-27783 fix(Subscription): reorder updation of end date (backport #27783)
…_develop fix(Subscription): reorder updation of end date