Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Subscription): reorder updation of end date #27783

Merged

Conversation

hrwX
Copy link
Contributor

@hrwX hrwX commented Oct 4, 2021

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #27783 (4f5d82c) into develop (6019f60) will increase coverage by 0.00%.
The diff coverage is 91.17%.

@@           Coverage Diff            @@
##           develop   #27783   +/-   ##
========================================
  Coverage    54.55%   54.56%           
========================================
  Files         1248     1248           
  Lines        67518    67527    +9     
========================================
+ Hits         36836    36846   +10     
+ Misses       30682    30681    -1     
Impacted Files Coverage Δ
...next/accounts/doctype/subscription/subscription.py 82.02% <91.17%> (-0.12%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.80% <0.00%> (-3.66%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 87.01% <0.00%> (-1.30%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 67.90% <0.00%> (-0.44%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 70.86% <0.00%> (-0.24%) ⬇️
... and 9 more

barredterra
barredterra previously approved these changes Oct 5, 2021
erpnext/accounts/doctype/subscription/test_subscription.py Outdated Show resolved Hide resolved
erpnext/accounts/doctype/subscription/subscription.py Outdated Show resolved Hide resolved
@hrwX hrwX force-pushed the subscription_generation_fix_develop branch from 7c027bf to 656015d Compare October 6, 2021 15:48
@hrwX hrwX force-pushed the subscription_generation_fix_develop branch from 2be35f5 to ae657c7 Compare October 6, 2021 16:32
@barredterra
Copy link
Collaborator

@deepeshgarg007 why did you remove the backport-version-12-hotfix label? We found this issue in v12 and our main intention is fixing it there.

@deepeshgarg007
Copy link
Member

@deepeshgarg007 why did you remove the backport-version-12-hotfix label? We found this issue in v12 and our main intention is fixing it there.

The subscription doctype in v13 and v12 are quite different so I don't think an automated backport to v12 might have worked hence I removed the label. Also, we have stopped backporting using labels and using mergify for backporting now.

@barredterra
Copy link
Collaborator

@deepeshgarg007 thanks for the clarification. Lets get this merged and we'll see about the backport later.

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@deepeshgarg007 deepeshgarg007 merged commit bd310e2 into frappe:develop Oct 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

Command backport version-13-hotfix: success

Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 13, 2021
…-27783

fix(Subscription): reorder updation of end date (backport #27783)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…_develop

fix(Subscription): reorder updation of end date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New subscriptions not generated
4 participants