Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CRM Settings #27788

Merged
merged 19 commits into from
Dec 6, 2021
Merged

feat: CRM Settings #27788

merged 19 commits into from
Dec 6, 2021

Conversation

anupamvs
Copy link
Contributor

@anupamvs anupamvs commented Oct 5, 2021

Docs- https://docs.erpnext.com/docs/v13/user/manual/en/CRM/crm_settings

  • Moved out some settings from the Selling (Campaign Naming By, Default Quotation Validity Days, Close Opportunity After Days)

image
New Settings

  • Auto Creation of Contact for new Lead
  • Allowed users to create multiple leads from the same email
  • User can toggle the creation of Event on Next Contact Date for both Lead and Opportunity.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #27788 (069deb3) into develop (c56a450) will decrease coverage by 0.08%.
The diff coverage is 77.55%.

@@             Coverage Diff             @@
##           develop   #27788      +/-   ##
===========================================
- Coverage    55.27%   55.19%   -0.09%     
===========================================
  Files         1121     1122       +1     
  Lines        66760    66769       +9     
===========================================
- Hits         36901    36851      -50     
- Misses       29859    29918      +59     
Impacted Files Coverage Δ
erpnext/crm/doctype/crm_settings/crm_settings.py 0.00% <0.00%> (ø)
erpnext/startup/boot.py 0.00% <0.00%> (ø)
erpnext/crm/doctype/opportunity/opportunity.py 71.15% <83.33%> (+0.42%) ⬆️
erpnext/crm/doctype/lead/lead.py 64.46% <85.71%> (+0.54%) ⬆️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-22.42%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.38% <0.00%> (-3.85%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 65.38% <0.00%> (-1.93%) ⬇️
... and 19 more

@umairsy
Copy link
Member

umairsy commented Oct 5, 2021

  1. Introduce Column break in Lead and Opportunity section, to maintain left - right balance.
  2. Move first section in the last and put section heading. May be third section can be called "Quotation Settings", and out campaign setting under Leads.

erpnext/selling/doctype/crm_settings/crm_settings.json Outdated Show resolved Hide resolved
erpnext/selling/doctype/crm_settings/crm_settings.json Outdated Show resolved Hide resolved
erpnext/selling/doctype/crm_settings/crm_settings.json Outdated Show resolved Hide resolved
erpnext/selling/doctype/crm_settings/crm_settings.json Outdated Show resolved Hide resolved
erpnext/crm/doctype/opportunity/opportunity.py Outdated Show resolved Hide resolved
@ruchamahabal ruchamahabal merged commit 3928a40 into frappe:develop Dec 6, 2021
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
* feat: crm settings

* feat: CRM Settings

* feat: lead and opprtunity section

* feat: added CRM Settings in ERPNext Settings workspace

* fix: review chnages

* added patch

* fix: linter issues

* fix: linter issues

* fix: linter issues

* fix: removed crm settings from selling module

* fix: raw query to frappe.qb

* fix: removed hardcoded value

* fix: linter issue

* fix: simplify CRM Settings migration patch

Co-authored-by: Anupam Kumar <anupam@Anupams-MacBook-Air.local>
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
* feat: crm settings

* feat: CRM Settings

* feat: lead and opprtunity section

* feat: added CRM Settings in ERPNext Settings workspace

* fix: review chnages

* added patch

* fix: linter issues

* fix: linter issues

* fix: linter issues

* fix: removed crm settings from selling module

* fix: raw query to frappe.qb

* fix: removed hardcoded value

* fix: linter issue

* fix: simplify CRM Settings migration patch

Co-authored-by: Anupam Kumar <anupam@Anupams-MacBook-Air.local>
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants