Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pick list): group items based on item code and warehouse before printing #27809

Merged
merged 4 commits into from
Oct 27, 2021

Conversation

DeeMysterio
Copy link
Contributor

@DeeMysterio DeeMysterio commented Oct 5, 2021

Problem:

  • Similar items on Pick List locations table aren't grouped before printing when fetched using "Get Items" button.

Screenshot 2021-10-05 at 2 40 49 PM

Changes:

  • Added a setting called "Group Same Items" on Pick List under Printing Settings section.
  • Grouped items based on item code and warehouse before printing.

Above items grouped based on item code and warehouse:
Screenshot 2021-10-05 at 2 41 10 PM

Printing Settings:
Screenshot 2021-10-05 at 2 16 34 PM

no-docs

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #27809 (b0da6d1) into develop (a87c201) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #27809      +/-   ##
===========================================
+ Coverage    55.11%   55.19%   +0.07%     
===========================================
  Files         1255     1255              
  Lines        67889    67915      +26     
===========================================
+ Hits         37420    37485      +65     
+ Misses       30469    30430      -39     
Impacted Files Coverage Δ
erpnext/stock/doctype/pick_list/pick_list.py 67.00% <100.00%> (+2.35%) ⬆️
...tch_item_expiry_status/batch_item_expiry_status.py 69.81% <0.00%> (-24.53%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.80% <0.00%> (-3.66%) ⬇️
erpnext/stock/reorder_item.py 74.57% <0.00%> (-3.39%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 87.01% <0.00%> (-2.60%) ⬇️
erpnext/controllers/status_updater.py 85.71% <0.00%> (-1.86%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/stock/stock_ledger.py 85.71% <0.00%> (-0.55%) ⬇️
erpnext/stock/get_item_details.py 79.38% <0.00%> (-0.47%) ⬇️
erpnext/hr/utils.py 74.29% <0.00%> (-0.41%) ⬇️
... and 20 more

@ankush
Copy link
Member

ankush commented Oct 21, 2021

@DeeMysterio please add 1 unit test for this function. Else LGTM.

@ankush ankush added the needs-tests This PR needs automated unit-tests. label Oct 21, 2021
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Oct 27, 2021
@ankush ankush enabled auto-merge (rebase) October 27, 2021 05:38
@ankush ankush disabled auto-merge October 27, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants