Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: optimise test_component_amount_dependent_on_another_payment_days_based_component #27836

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

sagarvora
Copy link
Collaborator

No description provided.

@sagarvora sagarvora merged commit d36849e into frappe:develop Oct 6, 2021
@ankush
Copy link
Member

ankush commented Oct 6, 2021

I am not fully sure but recent failures could be related to frappe/frappe#14102

@sagarvora
Copy link
Collaborator Author

sagarvora commented Oct 6, 2021

I am not fully sure but recent failures could be related to frappe/frappe#14102

Me neither. But above get_value seems to be working. Hence optimise in the title.

It wasn't working because employee was expected to be a value, but was a dict.

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants