Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude inactive employees from auto attendance #27850

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

pateljannat
Copy link
Contributor

  1. Auto attendance schedule job failing on encounter of inactive employees.

Screenshot 2021-10-07 at 5 18 30 PM

Traceback (most recent call last):
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/core/doctype/scheduled_job_type/scheduled_job_type.py", line 81, in execute
    frappe.get_attr(self.method)()
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/erpnext/erpnext/hr/doctype/shift_type/shift_type.py", line 110, in process_auto_attendance_for_all_shifts
    doc.process_auto_attendance()
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/erpnext/erpnext/hr/doctype/shift_type/shift_type.py", line 44, in process_auto_attendance
    self.mark_absent_for_dates_with_no_attendance(employee)
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/erpnext/erpnext/hr/doctype/shift_type/shift_type.py", line 89, in mark_absent_for_dates_with_no_attendance
    mark_attendance(employee, date, 'Absent', self.name)
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/erpnext/erpnext/hr/doctype/attendance/attendance.py", line 131, in mark_attendance
    attendance.insert()
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/model/document.py", line 238, in insert
    self.run_before_save_methods()
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/model/document.py", line 968, in run_before_save_methods
    self.run_method("validate")
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/model/document.py", line 860, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/model/document.py", line 1158, in composer
    return composed(self, method, *args, **kwargs)
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/model/document.py", line 1141, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/model/document.py", line 854, in <lambda>
    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/erpnext/erpnext/hr/doctype/attendance/attendance.py", line 18, in validate
    validate_active_employee(self.employee)
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/erpnext/erpnext/hr/utils.py", line 569, in validate_active_employee
    get_link_to_form("Employee", employee)), InactiveEmployeeStatusError)
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/__init__.py", line 437, in throw
    msgprint(msg, raise_exception=exc, title=title, indicator='red', is_minimizable=is_minimizable, wide=wide, as_list=as_list)
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/__init__.py", line 416, in msgprint
    _raise_exception()
  File "/home/frappe/benches/bench-version-13-2021-09-28/apps/frappe/frappe/__init__.py", line 370, in _raise_exception
    raise raise_exception(msg)
erpnext.hr.doctype.employee.employee.InactiveEmployeeStatusError: Transactions cannot be created for an Inactive Employee <a href="https://raissyon.erpnext.com/app/employee/Muqthar%20Kettinakath">Muqthar Kettinakath</a>.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #27850 (00f7f97) into develop (2b9b158) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #27850      +/-   ##
===========================================
+ Coverage    54.44%   54.47%   +0.03%     
===========================================
  Files         1254     1254              
  Lines        67750    67750              
===========================================
+ Hits         36885    36906      +21     
+ Misses       30865    30844      -21     
Impacted Files Coverage Δ
erpnext/hr/doctype/shift_type/shift_type.py 21.51% <0.00%> (ø)
...eorder_level/itemwise_recommended_reorder_level.py 90.56% <0.00%> (-3.78%) ⬇️
erpnext/stock/reorder_item.py 74.57% <0.00%> (-2.55%) ⬇️
erpnext/support/doctype/issue/issue.py 63.59% <0.00%> (-0.98%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.55% <0.00%> (-0.58%) ⬇️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.34% <0.00%> (ø)
erpnext/stock/stock_ledger.py 85.71% <0.00%> (+0.18%) ⬆️
erpnext/accounts/utils.py 59.38% <0.00%> (+0.18%) ⬆️
.../report/accounts_receivable/accounts_receivable.py 67.90% <0.00%> (+0.21%) ⬆️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 71.09% <0.00%> (+0.23%) ⬆️
... and 12 more

@pateljannat pateljannat merged commit 8de5f1f into frappe:develop Oct 14, 2021
@pateljannat
Copy link
Contributor Author

@Mergifyio backport version-13-hotfix

@pateljannat
Copy link
Contributor Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

backport version-13-hotfix

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

backport version-13-pre-release

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants