fix: consolidated report not consider company currency

[rohitwaghchaure]

Multi-currency issue in Consolidated report

Issue
Created child-parent company, parent company has currency INR and child company has Currency USD, system was showing

After Fix

Multi-currency COA for parent and child company

Issue
If you add new account in the parent company then system creates the same account in all the child company with currency same as parent company currency, but if the child company belongs to different currency then it set incorrect currency/

After Fix
System will use company currency while adding new Account from parent company to child company

[codecov]

Codecov Report

Merging #27863 (19d14da) into develop (64c1347) will increase coverage by 0.01%.
The diff coverage is 1.63%.

@@             Coverage Diff             @@
##           develop   #27863      +/-   ##
===========================================
+ Coverage    54.49%   54.50%   +0.01%     
===========================================
  Files         1248     1248              
  Lines        67521    67556      +35     
===========================================
+ Hits         36795    36823      +28     
- Misses       30726    30733       +7     

Impacted Files	Coverage Δ
...cial_statement/consolidated_financial_statement.py	0.00% <0.00%> (ø)
erpnext/accounts/doctype/account/account.py	71.09% <50.00%> (+0.11%)	⬆️
...ctype/woocommerce_settings/woocommerce_settings.py	80.39% <0.00%> (-3.93%)	⬇️
erpnext/education/doctype/student/student.py	73.95% <0.00%> (-3.13%)	⬇️
...ion/doctype/course_enrollment/course_enrollment.py	45.09% <0.00%> (-1.97%)	⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py	91.36% <0.00%> (-1.44%)	⬇️
...ice_creation_tool/opening_invoice_creation_tool.py	60.41% <0.00%> (-0.70%)	⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py	78.62% <0.00%> (-0.69%)	⬇️
erpnext/stock/get_item_details.py	79.38% <0.00%> (-0.47%)	⬇️
erpnext/selling/doctype/sales_order/sales_order.py	76.39% <0.00%> (-0.46%)	⬇️
... and 16 more

[rohitwaghchaure]

@Mergifyio backport version-13-hotfix

[mergify]

Command backport version-13-hotfix: success

Backports have been created

• #27898 fix: consolidated report not consider company currency (backport #27863) has been created for branch version-13-hotfix

[centaur78]

hi @rohitwaghchaure

Just got the below error when trying to view the report

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 66, in application
    response = frappe.api.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 54, in handle
    return frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 31, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 67, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1205, in call
    return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 621, in wrapper_fn
    retval = fn(*args, **get_newargs(fn, kwargs))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/query_report.py", line 233, in run
    result = generate_report_result(report, filters, user, custom_columns)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/query_report.py", line 75, in generate_report_result
    res = report.execute_script_report(filters)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/report/report.py", line 122, in execute_script_report
    res = self.execute_module(filters)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/report/report.py", line 139, in execute_module
    return frappe.get_attr(method_name)(frappe._dict(filters))
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/report/consolidated_financial_statement/consolidated_financial_statement.py", line 50, in execute
    data, message, chart, report_summary = get_balance_sheet_data(fiscal_year, companies, columns, filters)
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/report/consolidated_financial_statement/consolidated_financial_statement.py", line 78, in get_balance_sheet_data
    message, opening_balance = prepare_companywise_opening_balance(asset, liability, equity, companies)
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/report/consolidated_financial_statement/consolidated_financial_statement.py", line 118, in prepare_companywise_opening_balance
    opening_value += get_opening_balance(account_name, data, company)
TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'

[hasan-dodiya]

Child-Parent company issue in bank reconciliation tool currency issue.

Created child-parent company, parent company has currency INR and child company has Currency USD, system was showing

I have a USD bank account and when I display the bank reconciliation it shows the INR Symbol (company default)

[hasan-dodiya]

Child-Parent company issue in bank reconciliation tool currency issue.

Created child-parent company, parent company has currency INR and child company has Currency USD, system was showing

I have a USD bank account and when I display the bank reconciliation it shows the INR Symbol (company default)

@rohitwaghchaure Any update on this facing isuue