Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Status check for closed loans #27896

Merged
merged 3 commits into from
Oct 12, 2021

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Oct 11, 2021

  • Incorrect Maximum Loan Amount update
  • Loan Disbursal check for partial pledges
  • Status check post loan closure requested

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #27896 (af14ba4) into develop (6019f60) will decrease coverage by 0.22%.
The diff coverage is 81.81%.

@@             Coverage Diff             @@
##           develop   #27896      +/-   ##
===========================================
- Coverage    54.55%   54.33%   -0.23%     
===========================================
  Files         1248     1254       +6     
  Lines        67518    67722     +204     
===========================================
- Hits         36836    36794      -42     
- Misses       30682    30928     +246     
Impacted Files Coverage Δ
...ement/doctype/loan_application/loan_application.py 64.88% <0.00%> (-1.01%) ⬇️
erpnext/loan_management/doctype/loan/loan.py 70.76% <100.00%> (+0.11%) ⬆️
...ent/doctype/loan_disbursement/loan_disbursement.py 71.96% <100.00%> (+0.53%) ⬆️
...anagement/doctype/loan_repayment/loan_repayment.py 87.50% <100.00%> (ø)
...eport/item_variant_details/item_variant_details.py 32.14% <0.00%> (-52.39%) ⬇️
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 90.09% <0.00%> (-2.98%) ⬇️
... and 29 more

@deepeshgarg007 deepeshgarg007 merged commit 3750a88 into frappe:develop Oct 12, 2021
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2021

Command backport version-13-hotfix: success

Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 12, 2021
…-27896

fix: Status check for closed loans (backport #27896)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
* fix: Status check for closed loans

* fix: Incorrect maximum loan amount update

* fix: Linting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant